Skip to content

Commit

Permalink
when force-sending SCORM data to the fallback, use cmi.completion_sta…
Browse files Browse the repository at this point in the history
…tus for `completed`

fixes #300

I also noticed that the message "Attempt data is being saved to the database. Please wait."
is shown after the attempt is ended due to passing the "available until"
time. This commit changes it so that text is not shown when the attempt
is automatically ended.
  • Loading branch information
christianp committed Dec 20, 2023
1 parent 573a64d commit d7d6efb
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion numbas_lti/static/api.js
Expand Up @@ -672,7 +672,7 @@ SCORM_API.prototype = {
},
body: JSON.stringify({
batches: batches,
complete: force
complete: this.data['cmi.completion_status']=='completed'
})
});

Expand Down
2 changes: 1 addition & 1 deletion numbas_lti/static/run_attempt.css
Expand Up @@ -39,7 +39,7 @@ body.terminated #status-display .symbol, #status-display .symbol {
#status-display.ok .text-ok,
#status-display.confirmation .text-confirmation,
#status-display.unavailable-at .text-unavailable-at,
#status-display.terminated:not(.ok):not(.failed-final-ajax) .text-terminated,
#status-display.terminated:not(.ok):not(.failed-final-ajax):not(.ended) .text-terminated,
#status-display.failed-final-ajax .text-failed-final-ajax,
#status-display.loading-error .text-loading-error
{
Expand Down

0 comments on commit d7d6efb

Please sign in to comment.