Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignoring some linter errors to fix imports #6

Merged
merged 1 commit into from Jan 12, 2019
Merged

Ignoring some linter errors to fix imports #6

merged 1 commit into from Jan 12, 2019

Conversation

rkty13
Copy link
Contributor

@rkty13 rkty13 commented Jan 12, 2019

Fix for this issue:

➜  backend (master) ✔ pipenv run start
Traceback (most recent call last):
  File "app.py", line 1, in <module>
    from api import app
  File "/Users/robertkim/dev/personal/number-eleven/backend/api/__init__.py", line 4, in <module>
    from api.v0 import api_v0
  File "/Users/robertkim/dev/personal/number-eleven/backend/api/v0/__init__.py", line 3, in <module>
    import api.v0.routes  # pylint: disable=cyclic-import
  File "/Users/robertkim/dev/personal/number-eleven/backend/api/v0/routes.py", line 3, in <module>
    from api.v0 import api_v0
ImportError: cannot import name 'api_v0' from 'api.v0' (/Users/robertkim/dev/personal/number-eleven/backend/api/v0/__init__.py)

api_v0 can't be imported in routes.py because it's being imported in api.v0 module before api_v0 is initialized.

@josephjdkim
Copy link

Looks good

@josephjdkim josephjdkim reopened this Jan 12, 2019
@rkty13 rkty13 merged commit 431dec7 into master Jan 12, 2019
@rkty13 rkty13 deleted the fix-import branch January 12, 2019 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants