Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax compare_tables to allow unexpected Indexes and Streams #68

Closed
numberoverzero opened this issue Aug 29, 2016 · 0 comments
Closed
Assignees
Milestone

Comments

@numberoverzero
Copy link
Owner

The comparison strictness is an artifact of the 1:1 model:table mapping.

Now multiple Models backed by the same table may have their own GSIs and LSIs. The correct check would assert that the expected Indexes are a subset of available Indexes, and do the usual validation on each of the expected Indexes.

For the new Stream work in #17, it's fine if the table has a stream that the model didn't expect. Again, another Model may use the stream but this one does not. This should only fail if the Model expects a Stream that doesn't exist, or the StreamViewType doesn't match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant