Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispatch blocks, incorrect async #12

Closed
numberoverzero opened this issue Aug 28, 2015 · 0 comments · Fixed by #17
Closed

Dispatch blocks, incorrect async #12

numberoverzero opened this issue Aug 28, 2015 · 0 comments · Fixed by #17
Assignees
Labels

Comments

@numberoverzero
Copy link
Owner

After unpacking, the reading loop will yield from the event dispatch, which means it waits until all handlers run for the event, before continuing.

Instead, events.trigger should be a non-blocking call. That is, it should push the event into a queue, then return execution to the caller.


I'm working on accordian to fix this - however, in trying to use the 3.5 syntax (await and async as keywords) I've run into other problems. Once I've finished testing the library, I'll integrate it into bottom. This will require 3.5+ to use bottom, but the migration from 3.4 (current requirement) to 3.5 is virtually painless (I haven't seen any reports of problems migrating).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant