-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #134, run formatter #135
Conversation
…n vector transposes; add helper functions for mat-mat, mat-vec and vec-mat multiplication
…yword; run format (apparently for the first time); add .jshintrc; update public js
I did a quick run through and it looks good so far. Great job! Github tip: Add More Github secrets here: https://github.com/tiimgreen/github-cheat-sheet |
ignoring whitespace in diffs makes a huge difference in these commits, holy shet |
ping @LarryBattle |
The only suggestion I have right now is that |
// old version
matrix.transposeColumnVector([[1], [2], [3]])
// [ [1, 2, 3] ]
// new version
matrix.transposeColumnVector([[1],[2],[3]])
// [1, 2, 3] |
I could make |
I think the old version is just fine. |
I disagree. the intuitive way of thinking of a row vector is if one does in fact prefer it to represent a row vector as I agree with that to an extent. however, for a micro-optimization, one could call these methods directly instead. not sure if that's needed. |
although, the problem with that is that other functions may not return what the person expected. perhaps a setting, like |
will be closing this PR for reasons I'll mention later today |
don't be scared by the huge number of additions and deletions! the only new content is the following:
transposeRowVector
,transposeColumnVector
,transposeMatrix
(fix to matrix.transpose doesn't work correctly on vectors #134)multiplyMatMat
,multiplyMatVec
,multiplyVecMat
(helps to fix matrix.transpose doesn't work correctly on vectors #134).jshintrc
npm run format
doesn't change the indentation to 4 spaceseverything else is just
npm run format
doing its thing.@LarryBattle @KartikTalwar it'd be cool if you could look at the 2 first things I mentioned.