Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hyperlink for users to view num wallet transaction history … #1282

Merged
merged 1 commit into from Feb 21, 2022

Conversation

ruizehung
Copy link
Contributor

@ruizehung ruizehung commented Feb 16, 2022

Add hyperlinks in profile page for users to visit EtherScan or BscScan to check their NUM tracsaction history.

Test Plan

Demo video: https://youtu.be/wjWjio2NdhU

➜  capture-lite git:(feature-view-wallet-transaction-history) ✗ npm run test.ci

> capture-lite@0.48.1 test.ci
> npm run preconfig && ng test --no-watch --no-progress --source-map=false --browsers=ChromeHeadlessCI


> capture-lite@0.48.1 preconfig
> node set-secret.js

A secret file has generated successfully at ./src/app/shared/dia-backend/secret.ts 

16 02 2022 21:25:00.668:INFO [karma-server]: Karma v6.3.16 server started at http://localhost:9876/
16 02 2022 21:25:00.670:INFO [launcher]: Launching browsers ChromeHeadlessCI with concurrency unlimited
16 02 2022 21:25:00.671:INFO [launcher]: Starting browser ChromeHeadless
16 02 2022 21:25:07.012:INFO [Chrome Headless 98.0.4758.80 (Mac OS 10.15.7)]: Connected on socket csoS2gLUdDjg_MGKAAAB with id 76705077
Chrome Headless 98.0.4758.80 (Mac OS 10.15.7) MediaStore should write atomicly FAILED
        Error: Timeout - Async function did not complete within 5000ms (set by jasmine.DEFAULT_TIMEOUT_INTERVAL)
            at <Jasmine>
        Error: File does not exist.
            at FilesystemPluginWeb.<anonymous> (http://localhost:9876/_karma_webpack_/vendor.js:153986:35)
            at step (http://localhost:9876/_karma_webpack_/vendor.js:342099:23)
            at Object.next (http://localhost:9876/_karma_webpack_/vendor.js:342080:53)
            at fulfilled (http://localhost:9876/_karma_webpack_/vendor.js:342070:58)
            at ZoneDelegate.invoke (http://localhost:9876/_karma_webpack_/polyfills.js:8285:26)
            at ProxyZoneSpec.onInvoke (http://localhost:9876/_karma_webpack_/vendor.js:340089:39)
            at ZoneDelegate.invoke (http://localhost:9876/_karma_webpack_/polyfills.js:8284:52)
            at Zone.run (http://localhost:9876/_karma_webpack_/polyfills.js:8047:43)
            at http://localhost:9876/_karma_webpack_/polyfills.js:9189:36
            at ZoneDelegate.invokeTask (http://localhost:9876/_karma_webpack_/polyfills.js:8319:31)
Chrome Headless 98.0.4758.80 (Mac OS 10.15.7) MediaStore should delete atomicly FAILED
        Error: Timeout - Async function did not complete within 5000ms (set by jasmine.DEFAULT_TIMEOUT_INTERVAL)
            at <Jasmine>
        Error: File does not exist.
            at FilesystemPluginWeb.<anonymous> (http://localhost:9876/_karma_webpack_/vendor.js:153986:35)
            at step (http://localhost:9876/_karma_webpack_/vendor.js:342099:23)
            at Object.next (http://localhost:9876/_karma_webpack_/vendor.js:342080:53)
            at fulfilled (http://localhost:9876/_karma_webpack_/vendor.js:342070:58)
            at ZoneDelegate.invoke (http://localhost:9876/_karma_webpack_/polyfills.js:8285:26)
            at ProxyZoneSpec.onInvoke (http://localhost:9876/_karma_webpack_/vendor.js:340089:39)
            at ZoneDelegate.invoke (http://localhost:9876/_karma_webpack_/polyfills.js:8284:52)
            at Zone.run (http://localhost:9876/_karma_webpack_/polyfills.js:8047:43)
            at http://localhost:9876/_karma_webpack_/polyfills.js:9189:36
            at ZoneDelegate.invokeTask (http://localhost:9876/_karma_webpack_/polyfills.js:8319:31)
        Error: Timeout - Async function did not complete within 5000ms (set by jasmine.DEFAULT_TIMEOUT_INTERVAL)
            at <Jasmine>
Chrome Headless 98.0.4758.80 (Mac OS 10.15.7): Executed 213 of 213 (2 FAILED) (28.645 secs / 28.455 secs)
TOTAL: 2 FAILED, 211 SUCCESS

=============================== Coverage summary ===============================
Statements   : 51.05% ( 1732/3393 )
Branches     : 29.57% ( 288/974 )
Functions    : 40.65% ( 613/1508 )
Lines        : 52.98% ( 1565/2954 )
================================================================================
➜  capture-lite git:(feature-view-wallet-transaction-history) ✗

┆Issue is synchronized with this Asana task by Unito
┆Created By: Tammy Yang

Copy link
Contributor

@shc261392 shc261392 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@shc261392 shc261392 merged commit 309566b into develop Feb 21, 2022
@shc261392 shc261392 deleted the feature-view-wallet-transaction-history branch February 21, 2022 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants