Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Proof Interface #252

Merged
merged 27 commits into from
Nov 26, 2020
Merged

Refactor Proof Interface #252

merged 27 commits into from
Nov 26, 2020

Conversation

seanwu1105
Copy link
Contributor

@seanwu1105 seanwu1105 commented Nov 25, 2020 •
edited
Loading

Due to the limitation of Capacitor and Ionic framework, we cannot and should not use the same architecture from Starling Capture, which is based on Android framework. Thus, I have rewritten most parts regarding the data persistence. This includes:

  • Merge InformationRepository, SignatureRepository and SerializationService into ProofRepository and provide the same functionality.
  • Refactor CollectorService and the corresponding InformationProviders and SignatureProviders to accept newly merged Proof instance.
  • Refactor PublisherAlert and the corresponding publisher NumbersStoragePublisher and NumbersStorageApi to accept newly merged Proof instance.
  • Write unit tests to fully cover the refactored components, and thus the coverage has reached 70%.
  • Implement an adapter (old-proof-adapter) to provide the connection between Numbers Storage Back-end.

@seanwu1105
Implement stable and reliable data persistence solution with Capacito…
d6e6d16 
…r Filesystem plugin.

We use the plugin to create a JSON file for each table in database. The JSON contains a
single big array to store tuples. Also, we use an async-mutex to insure each insertion
and deletion is atomic. We write a fully covered unit tests to make sure the reliability.
@seanwu1105
Rename services/data/ dir to repositories.
a07f848
@seanwu1105
Replace utils/Storage with new Database and Table implementation.
ee11b71
@seanwu1105
WIP: building Proof class as a box containing self-verifiable info.
7412483
@seanwu1105
WIP: Implemented stringify and parse functions. Building self-verific…
67c703b 
…ation function.
@seanwu1105
Refactor proof with fully covered tests.
93f32b7
@seanwu1105
Implement getId and getThumbnail method on Proof class.
4dbe37c
@seanwu1105
WIP: Rename ProofRepository to OldProofRepository.
eb31486
@seanwu1105
Implement new ProofRepository with fully covered tests.
8cc6660
@seanwu1105
WIP: refactoring collector service to create new Proof object.
42c52e5
@seanwu1105
WIP: Extracting sortObjectDeeplyByKey from Proof class.
986845c
@seanwu1105
WIP: Implementing runAndStore function.
4ea1f9c
@seanwu1105
Refactor CollectorService.
a872721
@seanwu1105
WIP: Implement adapter between Proof and OldProof interface.
5e2f0c3
@seanwu1105
Add typing for image-blob-reduce lib.
1d11ba7
@seanwu1105
Use lodash/fp to replace static functions.
4efadf4
@seanwu1105
WIP: Update pages to display Proof object.
0ad3aa6
@seanwu1105
WIP: implement new facts and signature providers.
9f40c01
@seanwu1105
Remove old collector and providers.
9c2093e
@seanwu1105
Remove old info repo, signature repo, collector and publisher.
5f8eded
@seanwu1105
Rename publishers/*/data to publishers/*/repositories.
bf00b4b
@seanwu1105
Convert DefaultFactId to OldInformationName before publish to Numbers…
1e0abf5 
… Storage.
@seanwu1105
Add optional info collected from CapacitorProvider.
730ea6d
@seanwu1105
Group capture by formatted date.
4832a20
@seanwu1105
Fix wrongly merged decisions.
159c8dc
@seanwu1105 seanwu1105 added this to the beta7 milestone Nov 25, 2020
@seanwu1105 seanwu1105 self-assigned this Nov 25, 2020
shc261392
shc261392 approved these changes Nov 26, 2020
View reviewed changes
Copy link
Contributor

@shc261392 shc261392 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanwu1105 seanwu1105 merged commit df857b7 into develop Nov 26, 2020
@seanwu1105 seanwu1105 deleted the refactor-proof branch November 26, 2020 04:28
@seanwu1105 seanwu1105 mentioned this pull request Dec 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shc261392 shc261392 shc261392 approved these changes

Assignees

@seanwu1105 seanwu1105

Labels
None yet
Projects
None yet
Milestone
beta7
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@seanwu1105 @shc261392