CCAPI ver110 support #184
Closed
CCAPI ver110 support #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhylau
commented
Oct 30, 2021
| implementation "androidx.room:room-runtime:2.3.0" | ||
| implementation "androidx.room:room-ktx:2.3.0" | ||
| kapt "androidx.room:room-compiler:2.3.0" | ||
| kapt "org.xerial:sqlite-jdbc:3.34.0" |
There was a problem hiding this comment.
This is for compiling on M1 Macs.
benhylau
commented
Oct 30, 2021
Comment on lines
+13
to
+15
| <uses-permission android:name="android.permission.CHANGE_NETWORK_STATE" /> | ||
| <uses-permission android:name="android.permission.WRITE_SETTINGS" | ||
| tools:ignore="ProtectedPermissions" /> |
There was a problem hiding this comment.
Probably unnecessary since I commented out the WiFi network binding.
benhylau
commented
Oct 30, 2021
| @@ -63,7 +63,7 @@ suspend fun CanonCameraControlApi.waitUntilConnected( | |||
|
|
|||
| @JsonClass(generateAdapter = true) | |||
| data class Api( | |||
| val url: String, | |||
| val path: String, | |||
There was a problem hiding this comment.
This was the big breaking change.
benhylau
commented
Oct 30, 2021
| private lateinit var canonCameraControlApi: CanonCameraControlApi | ||
| private val proofCollector: ProofCollector by inject() | ||
| private lateinit var foregroundNotificationBuilder: NotificationCompat.Builder | ||
| private val beforeDestroyCallbacks = mutableSetOf<() -> Unit>() | ||
|
|
||
| @FlowPreview | ||
| override fun onStartCommand(intent: Intent, flags: Int, startId: Int): Int { | ||
| // bindProcessToWiFiNetwork() |
There was a problem hiding this comment.
This expectedly breaks Internet traffic. Proper fix will come from #22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks support for cameras activated for ver100, so we may not want to merge as is.