-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verbosity Replacement: Encoder.java #150
Comments
Hey David, is there a reason to use Logback rather than SLF4J? I feel the latter would keep end users' options more open. |
Isn't that the implementation of the Logging API you yourself suggested? :) |
For sure, but in the code itself we wouldn't use any logging implementation. Instead we would just code to the interface/facade, which feels the same but isn't backed by any real logging. When someone builds an application on So for this ticket, we wouldn't need/want Logback. If we provide examples or want logging in our tests, we can add Logback there. All that said.. I'm the new guy! lol |
So in other words, because the tests ARE downstream We need to consider the whole distribution, not only the specific issue On Sun, Jan 18, 2015 at 12:22 PM, Sean Connolly notifications@github.com
We find it hard to hear what another is saying because of how loudly "who |
Continued in #154 |
The Encoder class would benefit from the substitution of the "Verbosity" setting with an actual logging framework. Let's use Logback found here: http://logback.qos.ch/download.html as the actual logging framework. As a result, the log back jar(s) will need to be added to the build.gradle file and the pom.xml file.
For more information, please refer to the this information: https://gist.github.com/cogmission/bcc0b54aaf39b6b0108d
The text was updated successfully, but these errors were encountered: