Skip to content
This repository has been archived by the owner on Sep 1, 2023. It is now read-only.

add a byte-compile skip file list #1190

Merged
merged 2 commits into from
Aug 6, 2014
Merged

add a byte-compile skip file list #1190

merged 2 commits into from
Aug 6, 2014

Conversation

pgavazzi
Copy link
Contributor

@pgavazzi pgavazzi commented Aug 6, 2014

fixes #898

@rhyolight rhyolight added this to the Sprint 27 milestone Aug 6, 2014
@rhyolight
Copy link
Member

Brilliant! Thanks!


def skip_py_compile(file, cfile=None, dfile=None, doraise=False):
if os.path.basename(file) not in PY_COMPILE_SKIP_FILES:
orig_py_compile(file, cfile=cfile, dfile=dfile, doraise=doraise)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update to 2-space indentation here please?

@scottpurdy
Copy link
Contributor

This is fine with me for now but I tend to agree with Austin that the utility of the unimportable file may not be worth the benefit.

@rhyolight
Copy link
Member

Ok, merging with the option to purge UnImportableNode and this code at some point in the future.

rhyolight added a commit that referenced this pull request Aug 6, 2014
@rhyolight rhyolight merged commit 25d38ec into numenta:master Aug 6, 2014
@pgavazzi pgavazzi deleted the fix/pg/byte_compile_failure branch August 7, 2014 00:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure to byte-compile nupic/regions/UnimportableNode.py during install
3 participants