-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Run C++ nupic.core tests through new gtest interface #1299
Conversation
Merge numenta:master@HEAD
Merge numenta:master@HEAD
NUPIC_CORE_REMOTE = 'git://github.com/numenta/nupic.core.git' | ||
NUPIC_CORE_COMMITISH = '6b6afc1ef03dbfc2a183bacc6dfa85f5e758260a' | ||
NUPIC_CORE_REMOTE = 'git://github.com/utensil/nupic.core.git' | ||
NUPIC_CORE_COMMITISH = '7daa677c0a1b1296066ab2380dbe1e03b8c568cb' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming this commit sha is in numenta/nupic.core, the line above needs to be reverted to point to the right github fork.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @utensil is aware of it, he mentions this in TODO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR shouldn't require a reference to an outside fork in .nupic_modules, even if meant to be temporary. If these PRs need to be coordinated, let's get the nupic.core changes pushed to a branch on numenta/nupic.core so that at least the SHA is valid (even if not on master).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this is similar to the situation of the pip-installable PR. But adding a branch to numenta:nupic.core
can only be done by a owner.
@utensil @rhyolight @oxtopus let's re-trigger build here to see OSX , regarding the discussion in numenta/nupic.core-legacy#179 |
Merge numenta:master@HEAD
Triggered. Let's see what happens. |
@utensil I manually reset the status with the url http://issues.numenta.org:8081/validate?sha=d607a54d24779f170b88ea67487997193e98916b&postStatus=1&repo=numenta/nupic |
Updating the SHA1 caused this PR to be affected by the transformation to C++ 11, which is in progress and failing at #1264 . This is why the latest build is dark on all OS and compilers. |
Blocked by #1264. |
@rhyolight commented 10 hours ago
As the C++11 commits in |
…test Conflicts: .nupic_modules
This one's 👍 once .nupic_modules is updated to the right fork. |
…test Conflicts: CMakeLists.txt
I was confused by the git history at first and eventually figure this out. There was an attempt by oxtopus to merge my branch at #1408 but somehow failed the Mac build. And then oxtopus used a better method to link gtest: instead of linking gest built in But there was one piese missing in #1409, the So after I resolved conflicts with |
Closing this and go to #1413 |
Fixes #1298 .
This PR is NOT ready to merge until:
testeverything
nupic.core-legacy#179 is merged.nupic_modules
is updated accordingly