Skip to content
This repository has been archived by the owner on Sep 1, 2023. It is now read-only.

Bindings refactored #1610

Merged
merged 1 commit into from
Dec 11, 2014
Merged

Conversation

david-ragazzi
Copy link
Contributor

Fixes #1616.

This PR was created to simplify #1579 . Its objective is prepare bindings folder to c++ extensions build using setuptools.

Detailed changes in logic order:

  • Removed C# and Java outdated (and not supported) bindings. This change involved copy content from bindings/EngineInternalCommon.i into bindings/py/EngineInternalPy.i and bindings/py/algorithms/AlgorithmsImpl.i into bindings/py/algorithms/AlgorithmsPy.i
  • Remove IORange binding. It is not used by any module at nupic.
  • Move python bindings from $NUPIC/extensions/bindings/py into $NUPIC/nupic/bindings. Default setuptools pratice is that all c++ extensions should put into package structure.
  • Rename all *.i implementation files to snake_case. This is not required itself, but improve the readibility as they are now within nupic package structure and also generated wrappers and shared libraries names are derivations of their names: engine_internal.i => _engine_internal.so, engine_internal_wrap.cpp.
  • Update CMakeLists.txt with the changes above.

CC: @rhyolight @oxtopus @scottpurdy @subutai

@rhyolight
Copy link
Member

LGTM, but I want @scottpurdy to approve, which might take awhile because he's swamped with other work.

@scottpurdy
Copy link
Contributor

@david-ragazzi - thanks for pulling these changes out, this is much easier to review (albeit still quite a big change). Let me give it another look now

scottpurdy added a commit that referenced this pull request Dec 11, 2014
@scottpurdy scottpurdy merged commit ddd5d5b into numenta:master Dec 11, 2014
@david-ragazzi david-ragazzi deleted the refactor_bindings branch December 11, 2014 20:18
@david-ragazzi
Copy link
Contributor Author

Thanks @scottpurdy , I'm pulling make remotion still today..

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor bindings to adhere to setuptools standards
3 participants