This repository has been archived by the owner on Sep 1, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1616.
This PR was created to simplify #1579 . Its objective is prepare bindings folder to c++ extensions build using setuptools.
Detailed changes in logic order:
bindings/EngineInternalCommon.i
intobindings/py/EngineInternalPy.i
andbindings/py/algorithms/AlgorithmsImpl.i
intobindings/py/algorithms/AlgorithmsPy.i
IORange
binding. It is not used by any module at nupic.$NUPIC/extensions/bindings/py
into$NUPIC/nupic/bindings
. Defaultsetuptools
pratice is that all c++ extensions should put into package structure.*.i
implementation files tosnake_case
. This is not required itself, but improve the readibility as they are now within nupic package structure and also generated wrappers and shared libraries names are derivations of their names:engine_internal.i
=>_engine_internal.so
,engine_internal_wrap.cpp
.CC: @rhyolight @oxtopus @scottpurdy @subutai