This repository has been archived by the owner on Sep 1, 2023. It is now read-only.
Remove FlatSpatialPooler #2056
Merged
Remove FlatSpatialPooler #2056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
| @@ -1789,6 +1789,56 @@ def testWrite(self): | |||
| self.assertSetEqual(indices1, indices2) | |||
|
|
|||
|
|
|||
| def testRandomSPDoesNotLearn(self): | |||
There was a problem hiding this comment.
This test was ported from FlatSP and works fine.
david-ragazzi
force-pushed
the
remove_old_SPs_FlatSpatialPooler
branch
3 times, most recently
from
5ca46e2
to
70531a6
Compare
david-ragazzi
force-pushed
the
remove_old_SPs_FlatSpatialPooler
branch
from
70531a6
to
d02ebb3
Compare
|
CC @chetan51 |
Merged
|
@chetan51 Ping... |
|
👍 |
rhyolight
added a commit
that referenced
this pull request
Apr 17, 2015
…lPooler Remove FlatSpatialPooler
|
|
||
| def compare(self, pySp, cppSp): | ||
| self.assertAlmostEqual(pySp.getNumColumns(), | ||
| cppSp.getNumColumns()) |
There was a problem hiding this comment.
I think this c++/py compatibility test should stay! (ofc ported to the new SP implementation, not FlatSP)
There was a problem hiding this comment.
I think this c++/py compatibility test should stay! (ofc ported to the new SP implementation, not FlatSP)
Relax, man.. 😌 Look these here:
There was a problem hiding this comment.
cool then! 😎
Sorry, I just saw the files removed in the recent pull, and none tests added...
|
I'm raising a finger of caution on the removed tests, thoughts @david-ragazzi @chetan51 ? |
mihail911
pushed a commit
to mihail911/nupic
that referenced
this pull request
Aug 5, 2015
…tSpatialPooler Remove FlatSpatialPooler
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #627