Skip to content
This repository has been archived by the owner on Sep 1, 2023. It is now read-only.

keep compiled files between compiles, make distclean #788

Merged
merged 7 commits into from Apr 9, 2014

Conversation

breznak
Copy link
Member

@breznak breznak commented Apr 9, 2014

1/ new target make distclean
2/ keeping precompiled objects during compilations - makes consequent builds much faster, only changed objects are recompiled.

when numenta/nupic.core-legacy#65 is merged and SHA here updated to it, the difference should be visible!

tester added 6 commits April 8, 2014 17:08
should speed up re-build process as only changed .o files are compiled again.
Use make clean to start fresh --eg when strange errors occur.
@breznak breznak added this to the Sprint 19 milestone Apr 9, 2014
@breznak breznak self-assigned this Apr 9, 2014
@breznak
Copy link
Member Author

breznak commented Apr 9, 2014

Actually not sure about Travis - it does delete all files at init, right? But definitely fast for user builds.

@rhyolight
Copy link
Member

@breznak Travis has a fresh environment and fresh checkout of the repo for every job. Is that what you are asking?

@breznak
Copy link
Member Author

breznak commented Apr 9, 2014

Ok, so travis would not gain any speed-advantage from this (unless we can copy object files from last build to build/temp ) . But developers (who rebuild often) definitely would.

@rhyolight
Copy link
Member

LGTM... @david-ragazzi ?

@david-ragazzi
Copy link
Contributor

What is LGTM?? hehe

@david-ragazzi
Copy link
Contributor

@breznak Wouldn't be better "make clean" instead of "make distclean"?

@rhyolight
Copy link
Member

What is LGTM?? hehe

Looks good to me. 👀

@david-ragazzi
Copy link
Contributor

Looks good to me. 👀

hummm

Waiting for @breznak answer..

@breznak
Copy link
Member Author

breznak commented Apr 9, 2014

Wouldn't be better "make clean" instead of "make distclean"?

I thought the same, but no. clean is reserved target for make. see that it already does something.
Dist clean is by convention a "hardcore version of clean", it'll remove all files from compile.

@breznak
Copy link
Member Author

breznak commented Apr 9, 2014

Btw, updated SHA, for the change to make sense.

@david-ragazzi
Copy link
Contributor

I thought the same, but no. clean is reserved target for make. see that it already does something.
Dist clean is by convention a "hardcore version of clean", it'll remove all files from compile.

👍

@david-ragazzi
Copy link
Contributor

LGTM, @rhyolight !

rhyolight added a commit that referenced this pull request Apr 9, 2014
keep compiled files between compiles, make distclean
@rhyolight rhyolight merged commit 068fa99 into numenta:master Apr 9, 2014
rhyolight added a commit to breznak/nupic that referenced this pull request Apr 15, 2014
keep compiled files between compiles, make distclean
@breznak breznak deleted the custom_targets branch January 8, 2016 12:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants