Skip to content
This repository has been archived by the owner on Sep 1, 2023. It is now read-only.

Move test_py_htm to nupic.core and refactor test #282

Merged
merged 2 commits into from
Dec 31, 2014

Conversation

david-ragazzi
Copy link
Contributor

Fixes #281

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 3d8f594 on david-ragazzi:include_test_py_region into 08731c8 on numenta:master.

@david-ragazzi
Copy link
Contributor Author

🍏 Ready to review and merge

@rhyolight
Copy link
Member

I want to hear what @subutai and @scottpurdy have to say.

@subutai
Copy link
Member

subutai commented Dec 31, 2014

How is PyRegionTest being run and tested in nupic.core? Doesn't it need access to the python bindings and python regions to execute?

@david-ragazzi
Copy link
Contributor Author

How is PyRegionTest being run and tested in nupic.core? Doesn't it need access to the python bindings and python regions to execute?

@subutai It is build in nupic.core but tested in nupic through Updates nupic.core to latest built SHA PRs. So all tests and README instructions remains in nupic. Only its build is perfomed on nupic.core because it doesn't need python support files to be linked: actually its compile/link flags are indentical to cpp_region_test (old testscpphtm) located in nupic.core.

@subutai
Copy link
Member

subutai commented Dec 31, 2014

@david-ragazzi Ah ok, got it. That makes sense to me - thanks! I am fine with this structure.

@subutai
Copy link
Member

subutai commented Dec 31, 2014

We might want to put some comments in the PyRegionTest with the purpose of the test plus David's explanation so that someone looking at it doesn't get confused.

@rhyolight
Copy link
Member

@subutai said:

We might want to put some comments in the PyRegionTest with the purpose of the test plus David's explanation so that someone looking at it doesn't get confused.

Good idea. @david-ragazzi do this and I'll merge it!

@david-ragazzi
Copy link
Contributor Author

@david-ragazzi do this and I'll merge it!

b853fe5

rhyolight added a commit that referenced this pull request Dec 31, 2014
Move test_py_htm to nupic.core and refactor test
@rhyolight rhyolight merged commit 11671d9 into numenta:master Dec 31, 2014
rhyolight added a commit to david-ragazzi/nupic.core that referenced this pull request Jan 5, 2015
Move test_py_htm to nupic.core and refactor test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move testpyhtm to nupic.core and refactor test folder
4 participants