-
Notifications
You must be signed in to change notification settings - Fork 275
Revert "Revert "use POSIX version of esrerror_r"" #54
Conversation
This reverts commit ecd6ba7. Conflicts: os/FStream.cpp Because it introduced problems on OSX Use strerror only, simplify
@rhyolight please test when u have time.. |
@breznak doing now... |
yes :) because it's |
Yeah I saw that as soon as I commented 😊 |
looks like travis is not eager to check this for us.. :/ |
@breznak There is a problem. In subsequent commits on |
@rhyolight Right, I see.. But what should we do? It has to be fixed in nupic.core and that file does not exist here anymore. That is the problem of being out-of-sync :/ I can try some git magic with time..but im not sure |
The only thing I think will work is to revert numenta/nupic-legacy#768 so nupic points to https://github.com/numenta/nupic.core/tree/3ecc06a2e0b175a74381330d64a4ab803b71863d once again. |
Or we can just accept the fact that |
Ok, if #56 passes and we merge it, we can then merge master into this PR and I will retry. |
I'd accept a short downtime on OSX build to get it sorted. Can't have 100% uptime when you're performing brain surgery.— On Fri, Apr 4, 2014 at 9:19 PM, Matthew Taylor notifications@github.com
|
Hi @rhyolight , merge this when possible, please.. |
Revert "Revert "use POSIX version of esrerror_r""
This reverts commit ecd6ba7.
Because it introduced problems on OSX
Use strerror only, simplify
Should fix #53