This repository has been archived by the owner on Sep 1, 2023. It is now read-only.
Remove root dir (REPOSITORY_DIR) from include paths #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use only the **/include/ paths
(are also in gitignore, just need to be removed from .git)
|
also removes left-over files tests_*.hpp which are autogenerated. @scottpurdy does this help the include issue you had? |
|
👍 |
|
@breznak - No I don't think it changes anything |
|
hold on, looks like cmake reverts the submodule so it wasn't using your version... will follow up once I get it to use your version |
|
Ok nvm it still doesn't resolve the issue. No change in the output / error message as far as I can tell. |
|
Confirmed tests still ran in travis. Merging. |
rhyolight
added a commit
that referenced
this pull request
Apr 9, 2014
Remove root dir (REPOSITORY_DIR) from include paths
dkeeney
pushed a commit
to dkeeney/nupic.core
that referenced
this pull request
Aug 31, 2018
Remove capnproto - udates from dkeeney
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I think it's not necessary. all include files should be in any of the **/include/ paths.