Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythorch-lightning 1.3 breaks python path #516

Merged
merged 1 commit into from
May 18, 2021

Conversation

lscheinkman
Copy link
Contributor

@lscheinkman lscheinkman commented May 17, 2021

pythorch-lightning 1.3 breaks python path by installing the integration tests and other unwanted files directly into the site-package directory confusing isort

…on tests and other unwanted files directly into the site-package directory confusing isort
@lscheinkman lscheinkman requested review from mrcslws and karangrewal and removed request for mrcslws May 17, 2021 23:25
Copy link
Contributor

@mrcslws mrcslws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this must have been fun tracking down...

@lscheinkman lscheinkman merged commit bfae744 into numenta:master May 18, 2021
@lscheinkman lscheinkman deleted the fix_isort branch May 18, 2021 01:19
@lscheinkman
Copy link
Contributor Author

Wow, this must have been fun tracking down...

I had clue left behind in my site-packages/integrations folder
https://github.com/PyTorchLightning/metrics/blob/master/integrations/__init__.py#L5

_LIGHTNING_GREATER_EQUAL_1_3 = _compare_version("pytorch_lightning", operator.ge, "1.3.0")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants