Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flatten_chains and the relevant tests #150

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Conversation

houpc
Copy link
Member

@houpc houpc commented Oct 25, 2023

The function merge_all_chains() has a bug, as shown in the test/computation_graph.jl/line 302-308.

The added function flatten_all_chains() should fix this bug and be used in optimize!() to replace merge_all_chains().

@houpc houpc added bug Something isn't working enhancement New feature or request labels Oct 25, 2023
@houpc houpc self-assigned this Oct 25, 2023
src/computational_graph/optimize.jl Outdated Show resolved Hide resolved
src/computational_graph/transform.jl Outdated Show resolved Hide resolved
src/computational_graph/optimize.jl Outdated Show resolved Hide resolved
src/computational_graph/optimize.jl Outdated Show resolved Hide resolved
src/computational_graph/optimize.jl Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f0cee8b) 64.41% compared to head (b78ca2a) 64.35%.
Report is 1 commits behind head on computgraph.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff               @@
##           computgraph     #150      +/-   ##
===============================================
- Coverage        64.41%   64.35%   -0.07%     
===============================================
  Files               62       62              
  Lines             4353     4303      -50     
===============================================
- Hits              2804     2769      -35     
+ Misses            1549     1534      -15     
Files Coverage Δ
src/computational_graph/ComputationalGraph.jl 100.00% <ø> (ø)
src/computational_graph/optimize.jl 94.81% <100.00%> (+8.56%) ⬆️
src/computational_graph/transform.jl 96.85% <100.00%> (-0.43%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@houpc houpc merged commit d174936 into computgraph Oct 26, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants