Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support html-webpack-plugin@4 #52

Merged
merged 2 commits into from
Oct 29, 2018
Merged

feat: support html-webpack-plugin@4 #52

merged 2 commits into from
Oct 29, 2018

Conversation

snadn
Copy link
Contributor

@snadn snadn commented Oct 11, 2018

resolve #51

@snadn
Copy link
Contributor Author

snadn commented Oct 25, 2018

@numical Can this pr be merged?

@debanjanbasu
Copy link

This is super important. For many projects, can this PR be merged please ???

@numical
Update package.json
8d0c19b 
Updated patch version.
numical
numical approved these changes Oct 29, 2018
View reviewed changes
Copy link
Owner

@numical numical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. I am very slow with support at the moment.
Thanks very much @snadn - this is great - nice to have a PR submitted with the tests updated too.
Note I have updated the patch version.

@numical numical merged commit 87ff0a5 into numical:master Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@numical numical numical approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

not work with html-webpack-plugin@4
3 participants
@snadn @debanjanbasu @numical