Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future of Paxmod #33

Closed
numirias opened this issue Feb 2, 2019 · 5 comments
Closed

Future of Paxmod #33

numirias opened this issue Feb 2, 2019 · 5 comments

Comments

@numirias
Copy link
Owner

numirias commented Feb 2, 2019

A couple of notes, in case you're using Paxmod:

Since Firefox regularly introduces UI changes that require patches in Paxmod, it's quite time-consuming to keep the add-on working. Therefore, in the new releases, I'm just focusing on the few core features and I've dropped a lot of other stuff - most of which was implemented at a time where the default UI was more painful to use and the available WebExtensions APIs weren't very powerful.

What stays:

  • Multiple tab rows
  • Site-dependent tab colors
  • Some customization knobs (and the ability to add custom CSS)

What's gone:

  • UI tweaks, theming and color settings. By now, Firefox has a pretty good theme infrastructure and makes it easy to build your own themes. Also, rearranging stuff and changing the UI density under Customize works pretty well anyway.

(FWIW, I've also started working on a small add-on to customize themes ad-hoc, so if you're missing the ability to quickly adjust colors in the settings, maybe that'll help (once it's done).)

@nt1m
Copy link

nt1m commented Apr 8, 2019

@numirias The theme_experiment feature should make it easier to maintain your extension in case you haven't seen it:

{
  "manifest_version": 2,
  "name": "Theme experiment",
  "description": "Example of a theme experiment",
  "version": "1.0",
  "theme": {
    "colors": {
      "popup_affordance": [128,128,128]
    },
    "images": {
      "theme_toolbar": "toolbar.jpg"
    }
  },
  "theme_experiment": {
    "stylesheet": "style.css",
    "colors": {
      "popup_affordance": "--arrowpanel-dimmed"
    },
    "images": {
      "theme_toolbar": "--toolbar-bgimage"
    },
    "properties": {
      "toolbar_image_alignment": "--toolbar-bgalignment"
    }
  }
}

The style.css stylesheet can be used to style those properties too:

#nav-bar {
   background-position: var(--toolbar-bgalignment);
}

You can then use the new properties you just defined in extension code too:

browser.theme.update({
  colors: {
    popup_affordance: "green",
  }
});

@nt1m
Copy link

nt1m commented Apr 8, 2019

Also, note that's there's a bug affecting theme_experiment that causes the experiment to only apply in the initial window it's loaded in, which has been fixed in Firefox 68: https://bugzilla.mozilla.org/show_bug.cgi?id=1482870

@Ladergorn
Copy link

Unfortunately Paxmod seems to be broken with 71.0a1 (2019-10-04) (64-bit). I'm not getting multi-row tabs anymore.
Thanks

@numirias
Copy link
Owner Author

numirias commented Oct 6, 2019

@Ladergorn I issued an update (v3.2). Just go to about:addons and Paxmod > Check for Updates.

@Ladergorn
Copy link

Ladergorn commented Oct 6, 2019 via email

@numirias numirias closed this as completed Oct 8, 2019
@numirias numirias unpinned this issue Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants