Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gh-73. Fix summary collected count when tests are deselected. #74

Merged

Conversation

schettino72
Copy link
Contributor

Added deselected count in summary.
Added CHANGELOG.md file.

@schettino72
Copy link
Contributor Author

Notice the name session.testscollected is wrong.

pytest-dev/pytest#9614

…ected.

Add `deselected` count to summary.
@numirias numirias force-pushed the gh73-fix-summary-collected-deselected branch from 36338ae to 0301341 Compare March 15, 2022 20:31
@numirias
Copy link
Owner

Appreciate you digging into the oddities of pytest's stats calculation logic! I changed the patch a bit to preserve functionality related to reporting collectors.

I also appreciate your suggestion of a dedicated CHANGELOG.md. I absolutely see why that's useful addition, but I'm going to look into that separately and read up on best practices first. So I'll not be merging it right now within this PR.

@numirias numirias merged commit 41a3453 into numirias:master Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants