handler: _update_step: remove calling of mark_selected
#94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueyed
force-pushed
the
rm-mark_selected-from-_update_step
branch
from
f5e9ae6
to
39f49ec
Compare
|
@numirias can you merge this? I've been using it for over a month without problems. |
This should not be necessary in general, since it gets triggered via `CursorMoved` already. It also might trigger an error due to `self._vim.current.window` not being a valid window anymore, when `cursor` gets accessed [1]. It also should not be using the global current window's cursor (which might be for another buffer!) to mark selected nodes in the buffer. 1: numirias#72
blueyed
force-pushed
the
rm-mark_selected-from-_update_step
branch
from
39f49ec
to
d3e46ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should not be necessary in general, since it gets triggered via
CursorMovedalready.It also might trigger an error due to
self._vim.current.windownotbeing a valid window anymore, when
cursorgets accessed [1].It also should not be using the global current window's cursor (which
might be for another buffer!) to mark selected nodes in the buffer.
1: #72