Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atari-py dependency doesn't seem maintained #69

Closed
rossbar opened this issue Mar 16, 2021 · 7 comments
Closed

atari-py dependency doesn't seem maintained #69

rossbar opened this issue Mar 16, 2021 · 7 comments

Comments

@rossbar
Copy link
Collaborator

rossbar commented Mar 16, 2021

The reinforcement learning tutorial depends on atari-py which doesn't seem to be actively maintained (last commit Aug 2019). The README indicates that it's in "maintenance mode" but there haven't been any active developments and the wheels are out of date. This latter necessitates that wheels be built locally, requiring cmake.

I'm not familiar with gym or atari-py so I don't know if there are any newer packages or viable alternatives. Does anyone know of any viable alternatives?

@melissawm
Copy link
Member

Installing gym[atari] from pip was enough for me, but maybe this has changed. @8bitmp3 any ideas?

@rossbar
Copy link
Collaborator Author

rossbar commented Mar 16, 2021

It will work if you have cmake and one of ffmpeg/avconv installed on your system (at least on *nix platforms). The wheel is being built locally though (at least for Python >= 3.8, I haven't tested with older versions).

@8bitmp3
Copy link
Contributor

8bitmp3 commented Mar 22, 2021

Thanks for bringing this up @rossbar. Is this about config.yaml?:

version: 2
jobs:
  build-docs:
    working_directory: ~/repo
    docker:
      - image: circleci/python:3.8.5-buster
    steps:
      - checkout

      - run:
          name: Install deps for building atari-py
          command: sudo apt-get install -y cmake ffmpeg
...

As @melissawm, gym[atari] should be enough to run the Atari simulation (pip install gym[atari] (https://github.com/openai/gym, last commit as of today was on Feb 16, 2021)). In the tutorial, we state that the user needs to install jupyter-book and gym[atari], so hopefully that's enough for them to try it out.

@rossbar
Copy link
Collaborator Author

rossbar commented Mar 22, 2021

pip install gym[atari] is just a convenient shorthand for installing both gym and atari-py (the requirements file is already set up this way), the latter being the problem. pip install gym[atari] will still result in the the atari-py wheel being built locally.

@8bitmp3
Copy link
Contributor

8bitmp3 commented Mar 23, 2021

@rossbar Good point. Let's hope the OpenAI team will fix gym[atari] if atari-pi starts breaking 🤔 A lot of reinforcement learning research is probably still being carried out on Atari 2600.

@rossbar
Copy link
Collaborator Author

rossbar commented Apr 5, 2021

See also #72

@rossbar
Copy link
Collaborator Author

rossbar commented Jun 17, 2021

The atari-py project is publishing wheels again, though there are new issues as noted in #87. Closing this for now to switch focus to the more relevant issue.

@rossbar rossbar closed this as completed Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants