Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected favicon.png (but not .ico) #501

Closed
adeak opened this issue Nov 25, 2021 · 13 comments
Closed

Unexpected favicon.png (but not .ico) #501

adeak opened this issue Nov 25, 2021 · 13 comments

Comments

@adeak
Copy link

adeak commented Nov 25, 2021

A few days ago I noticed that duckduckgo shows an unusual favicon for numpy.org:

duckduckgo search result screenshot showing surprising favicon next to numpy.org

Looking at the HTML source, I can see a favicon.png and a favicon.ico (probably related to #493).

The .ico (from https://numpy.org/images/favicon.ico) looks fine:

numpy .ico favicon: blue stylised blocks in a cube with a grey letter N, on transparent background

But the .png (from https://numpy.org/images/favicon.png) looks surprising:

numpy .png favicon: two grey rectangles and an orange one

Is this expected?

Taking a closer look at #493 it seems that the favicon.png shouldn't even be there, so it must be something there by accident/left over. But its existence shadows the favicon.ico we have now.

The Hugo theme page has the same favicon.png linked in its source:

    <title>Scientific Python Hugo Theme documentation</title>

    
    
<link rel="icon" type="image/png" href="./images/favicon.png" />
<link href="https://fonts.googleapis.com/css?family=Lato:400,900" rel="stylesheet">
<link rel="stylesheet" type="text/css" href="./css/style.min.973539e55bb9a3b263afa3bea3a5c42c6bc9388ce23c69a67bf0e629f1a941a0.css" integrity="sha256-lzU55Vu5o7Jjr6O&#43;o6XELGvJOIziPGmme/DmKfGpQaA=">
<link rel="stylesheet" type="text/css" href="./css/icons.css">


    
    

<link rel="icon" href="./images/favicon.ico" />
@stefanv
Copy link
Contributor

stefanv commented Nov 25, 2021

That's from the parent theme. It gets overridden for most browsers, but looks like not for DDG. I will implement a fix. Thanks for the report!

@Mukulikaa
Copy link

Maybe related? This is the logo I see on the Chrome app on my phone:

IMG_20220118_000950

@adeak
Copy link
Author

adeak commented Jan 17, 2022

@shaloo
Copy link
Contributor

shaloo commented Jan 18, 2022

The following two files seem to be non-numpy favicon.ico files that are getting inherited and not overwritten in case of android phone as reported above:

./themes/scientific-python-hugo-theme/static/images/favicon.ico
./themes/scientific-python-hugo-theme/themes/hugo-fresh/static/images/favicon.png

On iPhone, I see correct favicon when I browse https://numpy.org/docs link with latest site as of 01/18/22

@stefanv
Copy link
Contributor

stefanv commented Jan 19, 2022

Most browsers favor the last favicon specified, but this does not seem to work everywhere. I will update the theme to only display "our" favicons.

@jarrodmillman
Copy link
Member

The https://numpy.org/doc/ site is not generated by the scientific-python-hugo-them, so I am not sure why the scientific-python favicon appears. When I go to that page, I see the old scipy favicon. It looks like https://numpy.org/doc/ is generated from https://github.com/numpy/doc.

I've removed the hugo fresh icon, so it no longer appears here: https://numpy.org/images/favicon.png

I don't know how long DDG will cache the favicon. But they should eventually update now.

@Mukulikaa
Copy link

It looks like https://numpy.org/doc/ is generated from https://github.com/numpy/doc.

Does that repo accept PRs? I'd be happy to update favicon.ico and numpy_logo.png, which should fix the logos on that page.

@stefanv
Copy link
Contributor

stefanv commented Jan 28, 2022

Thanks, Mukulikaa. You can see they currently use the SciPy logo: https://numpy.org/doc/_static/favicon.ico

PR should be made here: https://github.com/numpy/doc/blob/main/index.html#L30

@jarrodmillman
Copy link
Member

DDG seems to be finding the correct favicon now:
screenshot

@adeak
Copy link
Author

adeak commented Jan 29, 2022

Curious, I'm still seeing the old logo. Firefox 97.0b8 on debian.
Screenshot from 2022-01-29 15-55-53
I checked and it's the same with the light theme. I'll just blame caching for now and post a comment if it's still wrong in a week.

@jarrodmillman
Copy link
Member

Yes, we probably have different caches. Please do post in a week or so when you check again. Thanks!

@Mukulikaa
Copy link

When I go to that page, I see the old scipy favicon.

I have opened numpy/doc#9 to fix this.

@adeak
Copy link
Author

adeak commented Feb 6, 2022

Cache finally gave in:
Screenshot from 2022-02-06 20-48-30

Thanks for the fix :)

@adeak adeak closed this as completed Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants