No test for 'fromregex' in r4960 (Trac #719)

[numpy-gitbot]

Original ticket http://projects.scipy.org/numpy/ticket/719 on 2008-04-05 by @stefanv, assigned to @teoliphant.

No test for 'fromregex' in r4960. Blocks release of 1.0.5.

[numpy-gitbot]

Title changed from No test for 'fromregex' in r1960 to No test for 'fromregex' in r4960 by @stefanv on 2008-04-05

[numpy-gitbot]

@jarrodmillman wrote on 2008-04-09

See r4990, r4986, r4961.

[numpy-gitbot]

@pv wrote on 2008-04-12

fromregex apparently doesn't work: it tries to reference array instead of np.array, and the use of kwds.values() instead of kwds.items() is also suspect. Patch with tests is attached.

One of the tests fails right now (test_record_2), because there is a problem with np.array and int32:

>>> import numpy as np
>>> np.array([('123',), ('456',)], dtype=[('num', np.int64)])
array([(123L,), (456L,)], 
      dtype=[('num', '<i8')])
>>> np.array([('123',), ('456',)], dtype=[('num', np.int32)])
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: expected a readable buffer object

[numpy-gitbot]

Attachment added by @pv on 2008-04-12: fix-fromregex.patch

[numpy-gitbot]

@pv wrote on 2008-04-12

The patch also changes semantics of fromregex. We can't rely on items in **kwd being in any specific order, so it's safer to accept a dtype instead of a bunch of keywords.

[numpy-gitbot]

@stefanv wrote on 2008-04-12

Great detective work, Pauli. I've created #1334 to address the record array problem.

[numpy-gitbot]

@stefanv wrote on 2008-04-12

Patch applied in r5026 (broken test disabled until #1334 is fixed). Thanks, Pauli!