Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Use Ubuntu 18.04 to run "full" test. #18531

Merged
merged 1 commit into from Mar 4, 2021
Merged

Conversation

charris
Copy link
Member

@charris charris commented Mar 2, 2021

NumPy does not build using the --coverage flag on Ubuntu 20.04, the problem seems to be gcc 9.3.0-17. Work around that by running on Ubuntu 18.04 instead.

@charris
Copy link
Member Author

charris commented Mar 2, 2021

Looks like "RUN_COVERAGE" causes the problem. Probably a compiler problem with gcc 9.3.0-17/

@charris charris changed the title CI: Test if RUN_COVERAGE is the reason "full" test fails. CI: Disable RUN_COVERAGE in "full" test. Mar 3, 2021
@mattip
Copy link
Member

mattip commented Mar 3, 2021

Is there an easy way to change the compiler: can we install gcc10.2 or update the base image to get a different compiler as a side effect?

@charris
Copy link
Member Author

charris commented Mar 3, 2021

There is ubuntu 20.10 with gcc 10.2, but I don't know if it is available.

@charris
Copy link
Member Author

charris commented Mar 3, 2021

Another work around is to use ubuntu-18.04. The current problems seem to come from ubuntu-latest upgrading to 20.04. None of these are true fixes, the problem lies either with gcc 9.3 or the einsum code.

@charris
Copy link
Member Author

charris commented Mar 3, 2021

Changing the compiler is possible, but I think we would want to compile python with the same compiler.

NumPy does not build using the `--coverage` flag on Ubuntu 20.04, the
problem seems to be gcc 9.3.0-17. Work around that by running on Ubuntu
18.04 instead.
@charris charris changed the title CI: Disable RUN_COVERAGE in "full" test. CI: Use Ubuntu 18.04 to run "full" test. Mar 3, 2021
@charris charris added 09 - Backport-Candidate PRs tagged should be backported and removed 25 - WIP labels Mar 3, 2021
@charris
Copy link
Member Author

charris commented Mar 3, 2021

The Azure pipeline failure is unrelated:

ModuleNotFoundError: No module named '_sqlite3'

@charris charris merged commit cb557b7 into numpy:master Mar 4, 2021
@charris charris deleted the test-full-ci branch March 4, 2021 01:18
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants