Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: unused function warnings in current build #25471

Closed
ngoldbaum opened this issue Dec 22, 2023 · 2 comments · Fixed by #25555
Closed

BLD: unused function warnings in current build #25471

ngoldbaum opened this issue Dec 22, 2023 · 2 comments · Fixed by #25555
Assignees
Labels
36 - Build Build related PR component: SIMD Issues in SIMD (fast instruction sets) code or machinery

Comments

@ngoldbaum
Copy link
Member

When I build the current main branch using clang on an ARM mac, I get the following warnings:

[119/314] Compiling C object numpy/_core/l...generated_loops_trigonometric.dispatch.c.o
../numpy/_core/src/umath/loops_trigonometric.dispatch.c.src:168:1: warning: unused function 'simd_cos_f64' [-Wunused-function]
simd_cos_f64(const double *src, npy_intp ssrc, double *dst, npy_intp sdst, npy_intp len)
^
../numpy/_core/src/umath/loops_trigonometric.dispatch.c.src:168:1: warning: unused function 'simd_sin_f64' [-Wunused-function]
simd_sin_f64(const double *src, npy_intp ssrc, double *dst, npy_intp sdst, npy_intp len)
^
2 warnings generated.
[136/314] Compiling C object numpy/_core/l...on-generated_loops_arithmetic.dispatch.c.o
../numpy/_core/src/umath/loops_arithmetic.dispatch.c.src:46:1: warning: unused function 'simd_divide_by_scalar_contig_s64' [-Wunused-function]
simd_divide_by_scalar_contig_s64(char **args, npy_intp len)
^
../numpy/_core/src/umath/loops_arithmetic.dispatch.c.src:112:1: warning: unused function 'simd_divide_by_scalar_contig_u64' [-Wunused-function]
simd_divide_by_scalar_contig_u64(char **args, npy_intp len)
^
2 warnings generated.
[253/314] Compiling C++ object numpy/linal...cpython-311-darwin.so.p/umath_linalg.cpp.o
../numpy/linalg/umath_linalg.cpp:2279:1: warning: unused function 'call_geev' [-Wunused-function]
call_geev(GEEV_PARAMS_t<fortran_complex>* params)
^
1 warning generated.
[276/314] Compiling C object numpy/_core/l.../meson-generated_loops_minmax.dispatch.c.o
../numpy/_core/src/umath/loops_minmax.dispatch.c.src:230:1: warning: unused function 'simd_binary_max_f32' [-Wunused-function]
simd_binary_max_f32(const npyv_lanetype_f32 *ip1, npy_intp sip1,
^
../numpy/_core/src/umath/loops_minmax.dispatch.c.src:230:1: warning: unused function 'simd_binary_min_f32' [-Wunused-function]
simd_binary_min_f32(const npyv_lanetype_f32 *ip1, npy_intp sip1,
^
../numpy/_core/src/umath/loops_minmax.dispatch.c.src:230:1: warning: unused function 'simd_binary_maxp_f32' [-Wunused-function]
simd_binary_maxp_f32(const npyv_lanetype_f32 *ip1, npy_intp sip1,
^
../numpy/_core/src/umath/loops_minmax.dispatch.c.src:230:1: warning: unused function 'simd_binary_minp_f32' [-Wunused-function]
simd_binary_minp_f32(const npyv_lanetype_f32 *ip1, npy_intp sip1,
^
../numpy/_core/src/umath/loops_minmax.dispatch.c.src:230:1: warning: unused function 'simd_binary_max_f64' [-Wunused-function]
simd_binary_max_f64(const npyv_lanetype_f64 *ip1, npy_intp sip1,
^
../numpy/_core/src/umath/loops_minmax.dispatch.c.src:230:1: warning: unused function 'simd_binary_min_f64' [-Wunused-function]
simd_binary_min_f64(const npyv_lanetype_f64 *ip1, npy_intp sip1,
^
../numpy/_core/src/umath/loops_minmax.dispatch.c.src:230:1: warning: unused function 'simd_binary_maxp_f64' [-Wunused-function]
simd_binary_maxp_f64(const npyv_lanetype_f64 *ip1, npy_intp sip1,
^
../numpy/_core/src/umath/loops_minmax.dispatch.c.src:230:1: warning: unused function 'simd_binary_minp_f64' [-Wunused-function]
simd_binary_minp_f64(const npyv_lanetype_f64 *ip1, npy_intp sip1,
^
8 warnings generated.

gcc doesn't seem to notice these

@ngoldbaum ngoldbaum added component: SIMD Issues in SIMD (fast instruction sets) code or machinery 36 - Build Build related PR labels Dec 22, 2023
@ngoldbaum ngoldbaum changed the title BUG: unused function warnings in current build BLD: unused function warnings in current build Dec 22, 2023
@rgommers
Copy link
Member

I've tried to fix these before, but my fix was incorrect. It doesn't seem easy all that easy to do. But yeah, it'd be great to get these cleaned up.

@seiko2plus
Copy link
Member

I will release a patch for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
36 - Build Build related PR component: SIMD Issues in SIMD (fast instruction sets) code or machinery
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants