Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

numpy.allclose parameter types do not allow float #7079

Closed
marcotama opened this issue Jan 20, 2016 · 1 comment
Closed

numpy.allclose parameter types do not allow float #7079

marcotama opened this issue Jan 20, 2016 · 1 comment
Labels
57 - Close? Issues which may be closable unless discussion continued

Comments

@marcotama
Copy link

Not sure if this bug is proper to be posted here or in the typing module... If this is the wrong place, please, point me to the right one.

Current type hints for parameters a and b of np.allclose are Union[ndarray, Iterable], but should be changed to Union[ndarray, Iterable, float] since the function supports this type of usage.

np.isclose suffers from a similar issue: even though is quite rare for that function to be used with two floats, it would be more precise to mark the type of a and b as Union[ndarray, Iterable, float].
@seberg seberg added the 57 - Close? Issues which may be closable unless discussion continued label Mar 31, 2019
@mattip
Copy link
Member

mattip commented Apr 25, 2019

Typing is not internal to NumPy. Closing. Please reopen if there is something to be done inside NumPy.

@mattip mattip closed this as completed Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
57 - Close? Issues which may be closable unless discussion continued
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@seberg @mattip @marcotama