Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make parameter a namedtuple #176

Merged
merged 1 commit into from
May 4, 2018
Merged

Make parameter a namedtuple #176

merged 1 commit into from
May 4, 2018

Conversation

timhoffm
Copy link
Contributor

@timhoffm timhoffm commented May 3, 2018 •
edited
Loading

Refactor the commonly used tuple (param, param_type, desc) to a namedtuple.

This is preparatory for reworking #175 which will fix #72. Apart from that using a named tuple instead of a plain tuple is an improvement by itself.

@timhoffm timhoffm mentioned this pull request May 3, 2018
Merged
jnothman
jnothman reviewed May 4, 2018
View reviewed changes
Copy link
Member

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great

@jnothman
Copy link
Member

jnothman commented May 4, 2018

I'm going to be bold and merge this

@jnothman jnothman merged commit 136d4dd into numpy:master May 4, 2018
@timhoffm timhoffm mentioned this pull request May 4, 2018
Closed
@timhoffm timhoffm deleted the parameters-namedtuple branch May 5, 2018 13:30
@larsoner larsoner mentioned this pull request Apr 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman left review comments

Assignees
No one assigned
Labels
type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Anonymous return values have their types populated in the name slot of the tuple.
3 participants
@timhoffm @jnothman @larsoner