[ocamlformat]: Version detection #41
Conversation
programs/ocamlformat.nix
Outdated
| builtins.getAttr "ocamlformat_${ | ||
| builtins.replaceStrings ["."] ["_"] | ||
| (optionValue (lib.findFirst (option: builtins.head option == "version") [] | ||
| (builtins.map (n: lib.splitString "=" n) (lib.splitString "\n" (builtins.readFile configFile))))) |
There was a problem hiding this comment.
It's a bit problematic that this is depending on an Import From Derivation to work. The builtins.readFile is reading the build result of the ocamlformat package that's passed in.
A better solution would be to set the meta.mainProgram of the package in nixpkgs. This would make ocamlformat work out of the box.
There was a problem hiding this comment.
But thanks for the contribution!
There was a problem hiding this comment.
It's a bit problematic that this is depending on an Import From Derivation to work. The
builtins.readFileis reading the build result of the ocamlformat package that's passed in.
I don't follow? builtins.readFile is not reading the build result of the ocamformat package nor is it reading any other derivation, what it is reading however is a path passed as a module option, which should be fine because its known pre-eval.
There is no IFD?
There was a problem hiding this comment.
My bad. Can you show me a usage example?
There was a problem hiding this comment.
My bad. Can you show me a usage example?
programs.ocamlformat = {
enable = true;
package = ./.ocamlformat;
};.ocamlformat:
profile = default
version = 0.24.1
There was a problem hiding this comment.
I see. Let's split it out into three different options so they can be better documented:
- package - leave that as before. Is only used if the ocamlformat file is not passed.
- pkgs - the package set for ocamlformat file to look into. defaults to nixpkgs.
- ocamlformat (name to be discussed) - type: none or path - path to the .ocamlformat file. Used to pick the right version of ocamlformat if passed.
There was a problem hiding this comment.
That makes sense,
I pushed up a commit, see if thats any good
I used configFile as opposed to ocamlformat to refer to the name
…two other options, pkgs and configFile
Note
There is no way to pass in config file,
--configtakes in manually placed options, not.ocamlformatfiles.