[poincare] Change replaceSymbolWithExpression implementation to be alike

deepReduce and deepBeautify
numworks · Sep 26, 2018 · 961a17b · 961a17b
1 parent 3e99b07
commit 961a17b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/poincare/src/expression.cpp b/poincare/src/expression.cpp
@@ -186,9 +186,8 @@ Evaluation<U> Expression::approximateToEvaluation(Context& context, Preferences:
 }
 
 Expression Expression::defaultReplaceSymbolWithExpression(char symbol, Expression expression) {
-  int nbChildren = numberOfChildren();
-  for (int i = 0; i < nbChildren; i++) {
-    replaceChildAtIndexInPlace(i, childAtIndex(i).replaceSymbolWithExpression(symbol, expression));
+  for (int i = 0; i < numberOfChildren(); i++) {
+    childAtIndex(i).replaceSymbolWithExpression(symbol, expression);
   }
   return *this;
 }

diff --git a/poincare/src/symbol.cpp b/poincare/src/symbol.cpp
@@ -312,6 +312,7 @@ Expression Symbol::replaceSymbolWithExpression(char symbol, Expression & express
     if (!p.isUninitialized() && p.node()->childNeedsParenthesis(value.node())) {
       value = Parenthesis(value);
     }
+    replaceWithInPlace(value);
     return value;
   }
   return *this;