Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph: Y-auto doesn't play well with a vertical asympote #241

Closed
homeostasie opened this issue Nov 15, 2017 · 5 comments
Closed

Graph: Y-auto doesn't play well with a vertical asympote #241

homeostasie opened this issue Nov 15, 2017 · 5 comments

Comments

@homeostasie
Copy link

homeostasie commented Nov 15, 2017

For a function such as 1/x, the y-auto option doesn't make much sense.

It tries to display values that are way too high which results in a shrunk-down plot.

1/x

And by the way, reaching the "axes/zoom/preadjustment" menu can be cumbersome.

Original french version

Pour une fonction comme 1/x l'option Y auto n'est pas du tout pertinente.

Il cherche à représenter des valeurs bien trop hautes et écrase alors la courbe dans un repère qui a de trop grandes graduations.

Exemple : https://i.imgur.com/3nFs4q9.png

De même l'accès au troisième sous menu : Axes; Zoom et Initialisation est souvent laborieuse.

@Ecco Ecco changed the title Graphique - Asympote verticale avec Y auto Graph: Y-auto doesn't play well with a vertical asympote Nov 15, 2017
@Ecco
Copy link
Contributor

Ecco commented Nov 15, 2017

Thank you very much for your report @homeostasie ! I translated your original report to english because we have contributors who can't speak french.

@homeostasie
Copy link
Author

Thanks for the translation, I'm not fluent and don't practice English enough lately...

@homeostasie
Copy link
Author

homeostasie commented Nov 15, 2017

I'm not sure.

I think constants in epsilon/apps/shared/interactive_curve_view_range.h are involved.

constexpr static float k_minFloat = 1E-8f;
constexpr static float k_upperMaxFloat = 1E+8f;
constexpr static float k_lowerMaxFloat = 9E+7f;
constexpr static float k_maxRatioPositionRange = 1E5f;

Maybe a little condition,
if we found an inf value when searching for upperMax and lowerMax, the neighborhood have to be ignore and this constants have to be found a little bit after the the inf.

I do not have so much time (like everyone, I know) at this of the year (class council) but I will try to get into the details after.

@artaxxx
Copy link
Collaborator

artaxxx commented May 24, 2018

Fixed in the last version

@artaxxx artaxxx closed this as completed May 24, 2018
@homeostasie
Copy link
Author

Nice.

RedGl0w pushed a commit to RedGl0w/epsilon that referenced this issue Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants