Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negative diameter circle turtle support #1519

Merged
merged 1 commit into from Apr 15, 2020

Conversation

RedGl0w
Copy link
Contributor

@RedGl0w RedGl0w commented Apr 14, 2020

This patch #1506

@NumWorksBot
Copy link

.text .rodata .bss .data
Base 640 932 bytes 231 699 bytes 174 952 bytes 208 bytes
Head 640 964 bytes 231 699 bytes 174 952 bytes 208 bytes
+ 32 bytes + 0 bytes + 0 bytes + 0 bytes
+ 0 % + 0 % + 0 % + 0 %

@artaxxx
Copy link
Collaborator

artaxxx commented Apr 14, 2020

Thanks @RedGl0w ! It works great!

@Ecco
Copy link
Contributor

Ecco commented Apr 14, 2020

One quick remark : aren't we re-inventing fabs() here? We were already using the same construct though.

@RedGl0w RedGl0w closed this Apr 14, 2020
@RedGl0w RedGl0w reopened this Apr 14, 2020
@RedGl0w
Copy link
Contributor Author

RedGl0w commented Apr 14, 2020

Sorry misscliclk :/

@NumWorksBot
Copy link

.text .rodata .bss .data
Base 640 932 bytes 231 699 bytes 174 952 bytes 208 bytes
Head 640 964 bytes 231 699 bytes 174 952 bytes 208 bytes
+ 32 bytes + 0 bytes + 0 bytes + 0 bytes
+ 0 % + 0 % + 0 % + 0 %

@RedGl0w
Copy link
Contributor Author

RedGl0w commented Apr 14, 2020

One quick remark : aren't we re-inventing fabs() here? We were already using the same construct though.

If you are talking of

(radius > 0 ? 1 : -1)

This was already used in the same line, so I thought the same it was, the better it was... If you prefer a cleaner solution, I can change the whole line 😄

@EmilieNumworks EmilieNumworks merged commit c15bb3d into numworks:master Apr 15, 2020
@RedGl0w RedGl0w deleted the NegativeDiameterCircle branch April 15, 2020 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants