Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emscripten keyboard scan #754

Merged
merged 2 commits into from
Nov 8, 2018
Merged

Emscripten keyboard scan #754

merged 2 commits into from
Nov 8, 2018

Conversation

Ecco
Copy link
Contributor

@Ecco Ecco commented Nov 8, 2018

Implement Ion::Keyboard::scan on Emscripten

@boricj
Copy link
Contributor

boricj commented Nov 8, 2018

Small nitpick: I don't think this will interrupt a Python script when the user presses the ESC key on its (physical) keyboard.

@Ecco
Copy link
Contributor Author

Ecco commented Nov 8, 2018

Indeed, it doesn't. It also doesn't expose the computer's physical keyboard keys (if any) to Ion::Keyboard::scan either. But it's a start 😄

@LeaNumworks LeaNumworks merged commit 9825c73 into numworks:master Nov 8, 2018
@boricj boricj mentioned this pull request Nov 28, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
platform-simulator-web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ecco @boricj @LeaNumworks