fix: fixing test fail

nunenuh · Aug 23, 2023 · e1d2213 · e1d2213
1 parent a7d970e
commit e1d2213
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 10 deletions.
diff --git a/.github/workflows/codecov.yml b/.github/workflows/codecov.yml
@@ -30,7 +30,10 @@ jobs:
       - name: Install dependencies
         run: make deps
 
-      - name: Test with Go Test and Coverage
+      - name: Test with Go Test
+        run: make test
+
+      - name: Test with Go Test with Coverage
         run: make test-coverage
 
       - name: Upload coverage reports to Codecov

diff --git a/.github/workflows/dockerhub.yml b/.github/workflows/dockerhub.yml
@@ -37,13 +37,16 @@ jobs:
       - name: Install dependencies
         run: make deps
 
-    #   - name: Test with Go Test
-    #     run: make test
+      - name: Test with Go Test
+        run: make test
+
+      - name: Test with Go Test with Coverage
+        run: make test-coverage
 
-      - name: build docker image
+      - name: Build docker image
         run: make docker-build
 
-      - name: build docker image
+      - name: Push docker image to Dockerhub
         run: make docker-push
 
       - name: Logout from DockerHub

diff --git a/.github/workflows/sonarcloud.yml b/.github/workflows/sonarcloud.yml
@@ -33,8 +33,11 @@ jobs:
       - name: Install dependencies
         run: make deps
 
-    #   - name: Test with Go Test
-    #     run: go test -v ./... -coverprofile=coverage.out
+      - name: Test with Go Test
+        run: make test
+
+      - name: Test with Go Test with Coverage
+        run: make test-coverage
 
       - name: SonarCloud Scan
         uses: SonarSource/sonarcloud-github-action@master

diff --git a/internal/domain/repository/user_repository_test.go b/internal/domain/repository/user_repository_test.go
@@ -53,11 +53,10 @@ func TestIUserRepository_GetByID(t *testing.T) {
 	// Set the mock behavior for the GetByID method
 	expectedUser := &entity.User{ID: 1, FullName: "John Doe"}
 	mock.GetByIDFunc = func(ID int) (*entity.User, error) {
-		x := expectedUser.ID
-		if x != ID {
+		if expectedUser.ID != ID {
 			return nil, fmt.Errorf("user not found")
 		}
-		return nil, fmt.Errorf("user not found")
+		return expectedUser, nil
 	}
 
 	// Create an instance of the IUserRepository interface using the mock