Set DisableImplicitNuGetFallbackFolder and bump Ubuntu on Travis #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And now Travis is failing with (both on this PR and on master) seems related to https://travis-ci.community/t/c-builds-are-failing-net-core-installation-error/3063 |
This will be the default in a couple of weeks, see https://blog.travis-ci.com/2019-04-15-xenial-default-build-environment
mikkelbu
force-pushed
the
set-DisableImplicitNuGetFallbackFolder
branch
from
6eefa8b
to
458fbc3
Compare
mikkelbu
changed the title
mikkelbu
added a commit
to nunit/nunit
that referenced
this pull request
Apr 21, 2019
The Linux build has started to fail in a similar manner to nunit/nunit-console#611, so we bump the Ubuntu version.
ChrisMaddock
pushed a commit
to nunit/nunit
that referenced
this pull request
Apr 21, 2019
The Linux build has started to fail in a similar manner to nunit/nunit-console#611, so we bump the Ubuntu version.
jnm2
reviewed
Apr 22, 2019
| @@ -9,6 +9,7 @@ | |||
| <TreatWarningsAsErrors>true</TreatWarningsAsErrors> | |||
| <Commandlineparameters>nunit.engine.tests.dll -process:Single</Commandlineparameters> | |||
| <LangVersion>7</LangVersion> | |||
| <DisableImplicitNuGetFallbackFolder>true</DisableImplicitNuGetFallbackFolder> | |||
There was a problem hiding this comment.
We could think about putting these repeated elements in src/Directory.Build.props.
There was a problem hiding this comment.
Strange coincidence. I was thinking the same during a long run today, but I could not remember whether we had such a file in this repo, and then I forgot all about it again :).
mikkelbu
added a commit
to mikkelbu/nunit-console
that referenced
this pull request
May 25, 2019
As proposed in nunit#611 (comment)
Merged
ChrisMaddock
pushed a commit
that referenced
this pull request
May 26, 2019
As proposed in #611 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make Azure DevOps and Travis pass.