Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set DisableImplicitNuGetFallbackFolder and bump Ubuntu on Travis #611

Merged
merged 2 commits into from Apr 19, 2019
Merged

Set DisableImplicitNuGetFallbackFolder and bump Ubuntu on Travis #611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c356be4
Set DisableImplicitNuGetFallbackFolder for all projects
mikkelbu Apr 18, 2019
458fbc3
Bump Ubuntu version to make build server green
mikkelbu Apr 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .travis.yml
View file
Open in desktop
Expand Up @@ -6,9 +6,9 @@ mono: 5.10.0 # Need 5.2+ for the included MSBuild.

matrix:
include:
- os: linux
- dist: xenial
install:
- wget -q https://packages.microsoft.com/config/ubuntu/14.04/packages-microsoft-prod.deb
- wget -q https://packages.microsoft.com/config/ubuntu/16.04/packages-microsoft-prod.deb
- sudo dpkg -i packages-microsoft-prod.deb
- sudo apt-get install apt-transport-https
- sudo apt-get update
Expand Down
1 change: 0 additions & 1 deletion appveyor.yml
View file
Open in desktop
Expand Up @@ -5,7 +5,6 @@ branches:
image: Visual Studio 2017

build_script:
- nuget restore src\NUnitEngine\mock-assembly\mock-assembly.csproj
- ps: .\build.ps1 -Target "Appveyor" -Configuration "Release"

# disable built-in tests.
Expand Down
1 change: 1 addition & 0 deletions src/NUnitConsole/nunit3-console.tests/nunit3-console.tests.csproj
View file
Open in desktop
Expand Up @@ -9,6 +9,7 @@
<NoWarn>1685</NoWarn>
<DebugType>Full</DebugType>
<LangVersion>7</LangVersion>
<DisableImplicitNuGetFallbackFolder>true</DisableImplicitNuGetFallbackFolder>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="NSubstitute" Version="2.0.3" />
Expand Down
1 change: 1 addition & 0 deletions src/NUnitConsole/nunit3-console/nunit3-console.csproj
View file
Open in desktop
Expand Up @@ -9,6 +9,7 @@
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<Commandlineparameters>nunit.engine.tests.dll -process:Single</Commandlineparameters>
<LangVersion>7</LangVersion>
<DisableImplicitNuGetFallbackFolder>true</DisableImplicitNuGetFallbackFolder>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could think about putting these repeated elements in src/Directory.Build.props.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange coincidence. I was thinking the same during a long run today, but I could not remember whether we had such a file in this repo, and then I forgot all about it again :).

</PropertyGroup>
<PropertyGroup>
<ApplicationManifest>app.manifest</ApplicationManifest>
Expand Down
1 change: 1 addition & 0 deletions src/NUnitEngine/notest-assembly/notest-assembly.csproj
View file
Open in desktop
Expand Up @@ -5,6 +5,7 @@
<TargetFrameworks>net35;netcoreapp1.1;netcoreapp2.0</TargetFrameworks>
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
<OutputPath>..\..\..\bin\$(Configuration)\</OutputPath>
<DisableImplicitNuGetFallbackFolder>true</DisableImplicitNuGetFallbackFolder>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="NUnit" Version="3.11.0" />
Expand Down
1 change: 1 addition & 0 deletions src/NUnitEngine/nunit-agent/nunit-agent-x86.csproj
View file
Open in desktop
Expand Up @@ -13,6 +13,7 @@
<IntermediateOutputPath>obj\$(Configuration)\x86\</IntermediateOutputPath>
<LangVersion>7</LangVersion>
<GenerateSupportedRuntime>false</GenerateSupportedRuntime>
<DisableImplicitNuGetFallbackFolder>true</DisableImplicitNuGetFallbackFolder>
</PropertyGroup>
<ItemGroup Condition="'$(TargetFramework)'=='net20'">
<Reference Include="System.Runtime.Remoting" />
Expand Down
1 change: 1 addition & 0 deletions src/NUnitEngine/nunit-agent/nunit-agent.csproj
View file
Open in desktop
Expand Up @@ -11,6 +11,7 @@
<ApplicationIcon>..\..\..\nunit.ico</ApplicationIcon>
<LangVersion>7</LangVersion>
<GenerateSupportedRuntime>false</GenerateSupportedRuntime>
<DisableImplicitNuGetFallbackFolder>true</DisableImplicitNuGetFallbackFolder>
</PropertyGroup>
<ItemGroup Condition="'$(TargetFramework)'=='net20'">
<Reference Include="System.Runtime.Remoting" />
Expand Down
1 change: 1 addition & 0 deletions src/NUnitEngine/nunit.engine.api/nunit.engine.api.csproj
View file
Open in desktop
Expand Up @@ -10,6 +10,7 @@
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<LangVersion>7</LangVersion>
<DisableImplicitNuGetFallbackFolder>true</DisableImplicitNuGetFallbackFolder>
</PropertyGroup>
<ItemGroup Condition="'$(TargetFramework)'=='net20'">
<Reference Include="System.Web" />
Expand Down
1 change: 1 addition & 0 deletions src/NUnitEngine/nunit.engine.tests/nunit.engine.tests.csproj
View file
Open in desktop
Expand Up @@ -11,6 +11,7 @@
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<DebugType>Full</DebugType>
<LangVersion>7</LangVersion>
<DisableImplicitNuGetFallbackFolder>true</DisableImplicitNuGetFallbackFolder>
</PropertyGroup>
<ItemGroup Condition="'$(TargetFramework)'=='net35'">
<Reference Include="System.Configuration" />
Expand Down
1 change: 1 addition & 0 deletions src/NUnitEngine/nunit.engine/nunit.engine.csproj
View file
Open in desktop
Expand Up @@ -9,6 +9,7 @@
<AssemblyOriginatorKeyFile>..\..\nunit.snk</AssemblyOriginatorKeyFile>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<LangVersion>7</LangVersion>
<DisableImplicitNuGetFallbackFolder>true</DisableImplicitNuGetFallbackFolder>
</PropertyGroup>
<ItemGroup Condition="'$(TargetFramework)'=='net20'">
<PackageReference Include="Mono.Cecil" Version="0.9.6.1" />
Expand Down