Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Argument File processing differences with NUnitLite #210

Merged
merged 3 commits into from
Apr 25, 2017

Conversation

CharliePoole
Copy link
Collaborator

Fixes #126

Made the following changes to the console runner options to bring it in line with NUnitLite's features:

  1. Implemented nesting of argument files to a maximum depth of 3
  2. Allowed arguments in quotes to extend to multiple lines in an argument file
  3. Fixed the implementation of comments in argument files
  4. To keep consistency with nunitlite, I ended up eliminating the separate ArgumentsFileParser class.
  5. Renamed various things for consistency.

Copy link
Member

@rprouse rprouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other that the change you made to NUnitLite, this looks good. Approving so you can merge when that change is made.

@rprouse
Copy link
Member

rprouse commented Apr 25, 2017

Looks good now, merging.

@rprouse rprouse merged commit 6e7d8f0 into master Apr 25, 2017
@rprouse rprouse deleted the issue-126 branch April 25, 2017 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants