Fix compiling the .NET 2.0 version of Mock Assembly in VS2017 #220
Conversation
|
@jnm2 I've pulled the docker changes that you made to the NUnit repo into this PR to help me track down why the Linux builds are failing with such a trivial change. I really like it, thanks 👍 |
| @@ -9,6 +9,7 @@ Note that assemblies in one layer must not reference those in any other layer, e | |||
| Developers should make sure not to introduce any other references. | |||
|
|
|||
| There are two ways to build NUnit: using the solution file in an IDE or through the build script. | |||
| See also [Building and testing for Linux on a Windows machine](#building-and-testing-for-linux-on-a-windows-machine). | |||
There was a problem hiding this comment.
Everything here copied verbatim from the NUnit repo.
| continue; | ||
| } | ||
|
|
||
| docker run --rm -it -v ${PSScriptRoot}:/nunit-console -w=/nunit-console mono:4.2.4 bash build.sh $args |
There was a problem hiding this comment.
I use 4.2.4 instead of latest because latest is crashing with a mono bug and we are ignoring those builds in Travis. See #211
| @@ -23,7 +23,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution | |||
| EndProject | |||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "nunit.engine.tests.netstandard", "src\NUnitEngine\nunit.engine.tests.netstandard\nunit.engine.tests.netstandard.csproj", "{BC22F0E4-0862-4F82-A912-C9A447FECBAD}" | |||
| EndProject | |||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "mock-assembly.netstandard", "src\NUnitEngine\mock-assembly\mock-assembly.netstandard.csproj", "{BC6C8155-2024-4F58-A006-18A15EA22A5C}" | |||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "mock-assembly.netstandard", "src\NUnitEngine\mock-assembly.netstandard\mock-assembly.netstandard.csproj", "{BC6C8155-2024-4F58-A006-18A15EA22A5C}" | |||
There was a problem hiding this comment.
Moved the .NET Standard version of mock-assembly into its own directory. The newer version of NuGet didn't like finding the .NET Standard version in the main project for some reason and the project.json fix didn't work. I got tired of experimenting, so took the easy route out.
|
Build is passing now, so this is ready for review. |
Fixes #216
This is the same fix I had to do to the main NUnit solutions. If .NET Core is installed and we have .NET Core projects in that directory, then standard desktop .NET Projects need the
project.jsonfile.I don't know why this was working on AppVeyor or if other people are having the same problem, but it fixes it for me.