Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NSubstitute to rewrite ConsoleRunnerTests #352

Merged
merged 1 commit into from
Jan 19, 2018
Merged

Add NSubstitute to rewrite ConsoleRunnerTests #352

merged 1 commit into from
Jan 19, 2018

Conversation

ChrisMaddock
Copy link
Member

Fixes #256.

This just breaks the unrelated work out of #320. The purpose of this is to make more use of NSubstitute in #320 - this issue just 'might-as-well' be fixed as it's now trivial.

To use NSubstitue nunit.console.tests has to become .NET 3.5 - however, nunit.engine.tests is already doing the same - a .NET 3.5 test assembly testing the .NET 2.0 nunit.engine.

Copy link
Collaborator

@CharliePoole CharliePoole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rprouse rprouse merged commit ed6697b into master Jan 19, 2018
@rprouse rprouse deleted the issue-256 branch January 19, 2018 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite ConsoleRunnerTests.ThrowsNUnitEngineExceptionWhenTestResultsAreNotWriteable()
3 participants