Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate use of ProjectService in agents and AbstractTestRunner #564

Merged
merged 2 commits into from
Mar 16, 2019
Merged

Eliminate use of ProjectService in agents and AbstractTestRunner #564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b547005
Eliminate use of ProjectService in agents as well as from AbstractTes…
CharliePoole Mar 5, 2019
8abe140
Remove agent refrence toSettingsService
CharliePoole Mar 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/NUnitEngine/nunit-agent/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,7 @@ public static void Main(string[] args)

// Custom Service Initialization
//log.Info("Adding Services");
engine.Services.Add(new SettingsService(false));
engine.Services.Add(new ExtensionService());
engine.Services.Add(new ProjectService());
jnm2 marked this conversation as resolved.
Show resolved Hide resolved
engine.Services.Add(new DomainManager());
engine.Services.Add(new InProcessTestRunnerFactory());
engine.Services.Add(new DriverService());
Expand Down
3 changes: 0 additions & 3 deletions src/NUnitEngine/nunit.engine/Runners/AbstractTestRunner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ public AbstractTestRunner(IServiceLocator services, TestPackage package)
{
Services = services;
TestRunnerFactory = Services.GetService<ITestRunnerFactory>();
ProjectService = Services.GetService<IProjectService>();
TestPackage = package;
}

Expand All @@ -50,8 +49,6 @@ public AbstractTestRunner(IServiceLocator services, TestPackage package)
/// </summary>
protected IServiceLocator Services { get; private set; }

protected IProjectService ProjectService { get; private set; }

protected ITestRunnerFactory TestRunnerFactory { get; private set; }

/// <summary>
Expand Down