Fix extension loading for extensions which target multiple runtimes #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah - turns out this was better tested than I thought...although that doesn't stop the check being in the wrong place! This needs a bit more refactoring that I really have time for today. Will come back to it at some point. |
ChrisMaddock
commented
Jan 10, 2021
| var candidate = new ExtensionAssembly(filePath, fromWildCard); | ||
|
|
||
| if (!CanLoadTargetFramework(Assembly.GetEntryAssembly(), candidate)) | ||
| return; | ||
|
|
There was a problem hiding this comment.
The addition of lines 364-5 is the only substantial change in this PR.
ChrisMaddock
changed the title
|
Apologies folks, I've done more re-formtting in this PR than is helpful. Have highlighted the only important change with a comment, this is ready for review now, so long as CI passes this time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #844.
There was an error in the extension selection logic, where an extension of a higher version could replace an extension of a lower version, even if the higher version could not be loaded in the current runtime. This changes brings the check of where an extension is valid in the current runtime forward to prevent that.
The actual change is in the first commit, the second commit is subsequent reformatting and removal of the old check. Unfortunately this whole piece of logic currnently relies on 'real files' and is untested - something I think we'll need to refactor in future.