Issue635 partial classes #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removed the need to check all methods for classes that only have read-only constants.
Do not check calls across compilation boundaries.
mikkelbu
approved these changes
Nov 30, 2023
...alyzers/DisposeFieldsAndPropertiesInTearDown/DisposeFieldsAndPropertiesInTearDownAnalyzer.cs
Show resolved
Hide resolved
Take into account that get only properties and readonly fields can be assigned to in a constructor.
This to cope with cases where a field and an explicit property have the same name.
mikkelbu
approved these changes
Dec 5, 2023
|
I'm facing the same exception being thrown. Any chance this fix could be rolled out into a 3.11 release? |
@alteredego I'll will see if I can get a release out this weekend - either a 3.11 or a 4.00 |
|
@mikkelbu - am I recommended to upgrade to 4.0+ and does this have a hard dependency on using NUnit 4? Thank you in advance! |
|
We will not backport the fix to 3.11, but the NUnit 4.X analyzers should work with both NUnit 3 and NUnt 4. |
|
I'll give 4.0.1 a go. Many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #635
Fixes #659