Remove donations requests #72
Conversation
| @@ -0,0 +1,38 @@ | |||
| FROM ruby:2.6.3-buster | |||
There was a problem hiding this comment.
A pretty standard Dockerfile for a Ruby development container. VS Code will mount the source into the container and expose the ports.
| @@ -0,0 +1,16 @@ | |||
| { | |||
There was a problem hiding this comment.
This is for VS Code only. Tells VS Code to open the project in a Docker container and configures it. Ignored otherwise. See the readme.
| @@ -0,0 +1,3 @@ | |||
| * text=auto eol=lf | |||
There was a problem hiding this comment.
Consistency for editing in a Linux environment.
| @@ -1,6 +1,7 @@ | |||
| source "https://rubygems.org" | |||
|
|
|||
| gem 'jekyll' | |||
| gem 'github-pages' | |||
| gem 'jekyll', '>= 3.8.5' | |||
There was a problem hiding this comment.
Fixes the security issues.
| @@ -1,12 +1,58 @@ | |||
| # NUnit.org website | |||
|
|
|||
| ## Installing Jekyll | |||
| To get started developing the website, you have two options. You can develop in a Docker Container using VS Code, or you can install Ruby locally and develop locally. | |||
There was a problem hiding this comment.
A lot more words, but a very nice development experience. I ❤️ Docker.
| atom_path: /atom.xml | ||
| host: 0.0.0.0 |
There was a problem hiding this comment.
Need to listen on all addresses so that we can forward the port from the Docker container to the host
There was a problem hiding this comment.
I only have a few comments as I know very little about Ruby, "Visual Studio Code Remote Development", and Jekyll, but as far as I can tell is looks correct. So I'll "approve with suggestions" 😄.
Should we also remove the file _includes\paypal.html ?
EDIT: Ps. And I look forward to try this out as I've not had the energy to install Ruby etc. just to solve e.g. #50. Now it sounds much more manageable (and I get to try out "Remote Development" in VS Code).
|
Thanks for the suggestions @mikkelbu, I've done them all. I think you will like the Docker experience in VS Code. It is very slick. I've been adding support to quite a few projects I work on and really like it. Maybe do NUnit next? 😄 |
Fixes #43
Fixes #52
We received a donation offer today, so I decided to remove the requests for donations from the front page because we aren't currently accepting them. In the process, I also added @mikkelbu to the core team and did some other cleanup and updating.
I'm working on a new computer and didn't want to install Ruby, so I added Docker support to the project instead. See the
Readme.mdfor more info.Lastly, I can't abide by the security warnings on this repo, so I fixed those too.
Sorry, this is a larger PR, but I wanted to get it all knocked off tonight.