Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cecil exceptions from engine #1009

Closed
CharliePoole opened this issue Nov 8, 2015 · 2 comments
Closed

Cecil exceptions from engine #1009

CharliePoole opened this issue Nov 8, 2015 · 2 comments

Comments

@CharliePoole
Copy link
Contributor

The engine can throw exceptions due to errors in Cecil Resolve(). I discovered this when working with the NUnit 3 VS Adapter. The errors are very hard to locate and occur when Cecil cannot resolve the item requested. The code assumes null will be returned rather than an exception being thrown.

We should find every place where we do a Resolve in the engine code and

  1. Catch it and take appropriate action
  2. Try to set up the resolver correctly so it doesn't occur.
@CharliePoole
Copy link
Contributor Author

Issue #1144 points to some code where we simply don't check the possible null return at all!

@CharliePoole
Copy link
Contributor Author

Issue moved to nunit/nunit-console #9 via ZenHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants