Issue 1181

[ChrisMaddock]

This catches the crash found in #1181. Under certain circumstances, the ExtensionService will scan every dll in the executing directory to look for extensions. If an unmanaged dll is encountered at this point, NUnit crashes.

(#1181 was closed as a sub-issue of #1009, although this PR only catches the single case found in #1181 - I haven't done anything further to investigate other cases.)

[CharliePoole]

This looks good to me, with the possible exception that maybe we should log any errors. @rprouse what do you think?

[CharliePoole]

Something else I just thought of... we can get to the code in question in two ways: (1) scanning a directory using a wild-card pattern and (2) because the file was explicitly listed in a .addins file. In the first case, it makes sense to silently ignore the error, but in the second it seems wrong. What do you think @ChrisMaddock and @rprouse ?

[ChrisMaddock]

@CharliePoole Thanks, the second use-case hadn't crossed my mind.

Sounds to me like FindExtensionsInAssembly() needs to know if it's scanning or looking at a specified assembly, and either skip, or throw an NUnitEngineException specifying the invalid file?

[CharliePoole]

That's what it seems to me. If the file was actually listed by name, it's a configuration error.

[ChrisMaddock]

Thanks @CharliePoole - have added that in.

[CharliePoole]

Looks good to me. We need a second review. @rprouse ?