NUnitLite ignores --workers option

[CharliePoole]

I came across this working on #164. Changing the number of test workers with the command-line --workers option didn't have any effect on the duration of the test. On investigation, it's clear that although the option is accepted there is no code to transmit it to the framework as a setting.

[oznetmaster]

			if (options.NumberOfTestWorkers >= 0)
				runSettings[FrameworkPackageSettings.NumberOfTestWorkers] = options.NumberOfTestWorkers;

[oznetmaster]

#if PARALLEL
		private int GetLevelOfParallelism ()
			{
			return Settings.ContainsKey (FrameworkPackageSettings.NumberOfTestWorkers)
				? (int)Settings[FrameworkPackageSettings.NumberOfTestWorkers]
					 : (LoadedTest.Properties.ContainsKey (PropertyNames.LevelOfParallelism)
						 ? (int)LoadedTest.Properties.Get (PropertyNames.LevelOfParallelism)
						 : NUnitTestAssemblyRunner.DefaultLevelOfParallelism);
			}
#endif

[oznetmaster]

@CharliePoole Not sure why you think it is not used?

[CharliePoole]

Experimentally and because there's no code for it in NUnitLite. NUnit has code to properly handle the setting, if it's there - as you show above. NUnitLite accepts it as a command-line setting but never passes that setting to the framework.

[CharliePoole]

I didn't see your first example, only the second. The code you cite is pretty much what I had to add to TextRunner.cs to get it to work. It's not in the master.

[oznetmaster]

That code was in nunitlite for a long time. No idea when it was removed. I did not write it.

[oznetmaster]

As far as I can tell it was there when I started working on 3.0

[oznetmaster]

I have been using that command line option to test the cf build for a long time.

[CharliePoole]

This isn't actually helping.

[oznetmaster]

Neither of those pieces of code are samples. They we're copied from my cf source.

[oznetmaster]

It might be relevant to determine when and why they were removed. Might be other related issues as well?

[CharliePoole]

I've been back as far as the first alpha release of 3.0. There has never been code to make the option work. Of course, the default setting has always worked, absent the command-line override.

[oznetmaster]

It was added to my CF build on 3/21/2015 at 12:01 PM, according to my version control system.

That was the only change on that date.

That was about eight days after I started working on NUnit.

[CharliePoole]

Unfortunately, nobody ever added it to the master repository.