Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some NUnit project's tests fail on systems with CultureInfo other than en #2179

Closed
gcichosz opened this issue May 19, 2017 · 2 comments · Fixed by #2185
Closed

Some NUnit project's tests fail on systems with CultureInfo other than en #2179

gcichosz opened this issue May 19, 2017 · 2 comments · Fixed by #2185

Comments

@gcichosz
Copy link
Contributor

The following tests fail on systems with comma decimal mark settings:

  • NUnit.Framework.Internal.EventListenerTextWriterTests.TestWriteDecimal
  • NUnit.Framework.Internal.EventListenerTextWriterTests.TestWriteDouble
  • NUnit.Framework.Internal.EventListenerTextWriterTests.TestWriteStringArg2
  • NUnit.Framework.Internal.EventListenerTextWriterTests.TestWriteStringArg3
  • NUnit.Framework.Constraints.LessThanConstraintTests.SimpleTolerance_Failure

The following test fails on systems with CultureInfo other than en:

  • NUnit.Framework.Internal.EventListenerTextWriterTests.TestWriteStringArg1

Steps to reproduce:

  1. Change system region, or language settings to one with comma decimal mark (Countries using Arabic numerals with decimal comma), and with language other than English
  2. Run the build script with -Target Test option
  3. See aforementioned tests fail
@gcichosz
Copy link
Contributor Author

I'm already on that issue, because it blocks me from running the tests properly, so someone can assign me to it. If not, I'm doing that anyways, and will update that issue with a PR 😉

@ChrisMaddock
Copy link
Member

Whoops! Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants