ValuesAttribute uses an outdated version of TestCaseAttribute's type coercion logic

[jnm2]

As part of fixing #2630, I copied many tests from TestCaseAttributeTests to ValueAttributeTests and had to remove them again because they failed.

nunit/src/NUnitFramework/tests/Attributes/TestCaseAttributeTests.cs

Lines 427 to 432 in c79e1c0

	[TestCase(1)]
	public void CanConvertIntToNullableLong(long? x)
	{
	Assert.That(x.HasValue);
	Assert.That(x.Value, Is.EqualTo(1));
	}

When translated to ValuesAttribute:

[Test]
public void CanConvertIntToNullableLong([Values(1)] long? x)
{
    Assert.That(x.HasValue);
    Assert.That(x.Value, Is.EqualTo(1));
}

Gives:

System.ArgumentException : Object of type 'System.Int32' cannot be converted to type 'System.Nullable`1[System.Int64]'.
   at System.RuntimeType.CheckValue(Object value, Binder binder, CultureInfo culture, BindingFlags invokeAttr)
   at System.Reflection.MethodBase.CheckArguments(Object[] parameters, Binder binder, BindingFlags invokeAttr, CultureInfo culture, Signature sig)
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture, Boolean skipVisibilityChecks)
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
   at System.Reflection.MethodBase.Invoke(Object obj, Object[] parameters)
   at NUnit.Framework.Internal.Reflect.InvokeMethod(MethodInfo method, Object fixture, Object[] args)

Before @ChrisMaddock brought #2104 to my attention, I had already fixed this one: https://github.com/nunit/nunit/compare/jnm2/values_type_coercion

I'm just going to leave this here until I have time to dig into #2104. #2104 looks huge and I don't want to jeopardize it, though perhaps it could be done in granular chunks.

Please comment.

[ChrisMaddock]

I agree with everything you've said. Let's discuss #2104 over on #2104. 😄

[stevenaw]

I think this was incidentally fixed when resolving #3053

[stevenaw]

I'm closing this issue. I believe it was fixed via #3053 and covered via a test:

nunit/src/NUnitFramework/tests/Attributes/ValuesAttributeTests.cs

Line 56 in ad49f27

public void CanConvertIntsToNullableLong([Values(5, int.MaxValue)]long? x)